pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve description of keys in tsvector
Date: Tue, 05 Sep 2023 04:58:19 +0000
Message-ID: <E1qdO8p-002TaS-GF@gemulon.postgresql.org> (raw)

Improve description of keys in tsvector

If all the bits of a key in a tsvector are true (marked with ALLISTRUE),
gtsvectorout() would show the following description:
"0 true bits, 0 false bits"

This is confusing, as all the bits are true, but this would be
equivalent to the information if siglen is 0.

This commit improves the output so as "all true bits" show instead in
this case.  Alexander has proposed a regression test for pageinspect,
not included here as it is rather expensive compared to its coverage
value.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/17950-6c80a8d2b94ec695@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aa0d3504560d40f4300a3d49d1c6c3bfc3b894e5

Modified Files
--------------
src/backend/utils/adt/tsgistidx.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)



Message-ID: <E1qdO8p-002TaS-GF@gemulon.postgresql.org>
Permalink:  ../E1qdO8p-002TaS-GF@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qdO8p-002TaS-GF@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve description of keys in tsvector
  In-Reply-To: <E1qdO8p-002TaS-GF@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox