pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix instability in 031_recovery_conflict.pl.
Date: Thu, 07 Sep 2023 02:40:58 +0000
Message-ID: <E1qe4x0-002kud-77@gemulon.postgresql.org> (raw)

Fix instability in 031_recovery_conflict.pl.

Where the test wants a VACUUM command to generate WAL that would
conflict with a session on the standby, it could transiently fail to do
so if it couldn't acquire a cleanup lock conditionally at that moment on
the primary.  VACUUM FREEZE will wait, so use that instead.

No back-patch for now, but that will be needed if/when the test is
re-enabled in back-branches.

Suggested-by: Andres Freund <andres@anarazel.de>
Reported-by: Christoph Berg <myon@debian.org>
Discussion: https://postgr.es/m/20230812210006.ei7tutzwcr5svyt6%40awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0174c2d213f69a4ba87932de706eedf3fbb5979e

Modified Files
--------------
src/test/recovery/t/031_recovery_conflict.pl | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)



Message-ID: <E1qe4x0-002kud-77@gemulon.postgresql.org>
Permalink:  ../E1qe4x0-002kud-77@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qe4x0-002kud-77@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix instability in 031_recovery_conflict.pl.
  In-Reply-To: <E1qe4x0-002kud-77@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox