From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move privilege check to the right place
Date: Thu, 07 Sep 2023 11:01:29 +0000
Message-ID: <E1qeClN-002nsn-Gt@gemulon.postgresql.org> (raw)
Move privilege check to the right place
Now that ATExecDropConstraint doesn't recurse anymore, so it's wrong to
test privileges "during recursion" there. Move the check to
dropconstraint_internal, which is the place where recursion occurs.
In passing, remove now-useless 'recursing' argument to
ATExecDropConstraint.
Discussion: https://postgr.es/m/202309051744.y4mndw5gwzhh@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ac22a9545ca906e70a819b54e76de38817c93aaf
Modified Files
--------------
src/backend/commands/tablecmds.c | 18 ++++++++----------
src/test/regress/expected/inherit.out | 21 +++++++++++++++++++++
src/test/regress/sql/inherit.sql | 21 +++++++++++++++++++++
3 files changed, 50 insertions(+), 10 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move privilege check to the right place
In-Reply-To: <E1qeClN-002nsn-Gt@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox