pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove some more "snapshot too old" vestiges.
Date: Fri, 08 Sep 2023 05:18:49 +0000
Message-ID: <E1qeTtJ-002uSz-6C@gemulon.postgresql.org> (raw)

Remove some more "snapshot too old" vestiges.

Commit f691f5b8 removed the logic, but left behind some now-useless
Snapshot arguments to various AM-internal functions, and missed a couple
of comments.

Reported-by: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wznj9qSNXZ1P1uWTUD_FeaTezbUazb416EPwi4Qr_jR_6A%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9f0602539db4573b89c09abab666e85b653940bd

Modified Files
--------------
contrib/amcheck/verify_nbtree.c             |  2 +-
src/backend/access/brin/brin.c              | 21 ++++++++---------
src/backend/access/brin/brin_revmap.c       |  8 +++----
src/backend/access/common/toast_internals.c |  3 +--
src/backend/access/gin/ginbtree.c           |  2 +-
src/backend/access/gin/gindatapage.c        |  7 +++---
src/backend/access/gin/ginget.c             | 28 +++++++++++------------
src/backend/access/gin/gininsert.c          |  2 +-
src/backend/access/heap/vacuumlazy.c        |  4 ----
src/backend/access/nbtree/nbtinsert.c       |  4 ++--
src/backend/access/nbtree/nbtpage.c         |  3 +--
src/backend/access/nbtree/nbtsearch.c       | 35 +++++++++--------------------
src/backend/access/spgist/spgscan.c         |  7 +++---
src/include/access/brin_revmap.h            |  4 ++--
src/include/access/gin_private.h            |  4 ++--
src/include/access/nbtree.h                 |  7 +++---
16 files changed, 56 insertions(+), 85 deletions(-)



Message-ID: <E1qeTtJ-002uSz-6C@gemulon.postgresql.org>
Permalink:  ../E1qeTtJ-002uSz-6C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qeTtJ-002uSz-6C@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove some more "snapshot too old" vestiges.
  In-Reply-To: <E1qeTtJ-002uSz-6C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox