pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Stabilize subscription stats test. 3+ messages / 1 participants [nested] [flat]
* pgsql: Stabilize subscription stats test. @ 2023-09-08 13:53 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Masahiko Sawada @ 2023-09-08 13:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize subscription stats test. The new test added by commit 68a59f9e9 disables the subscription and manually drops the associated replication slot. However, since disabling the subsubscription doesn't wait for a walsender to release the replication slot and exit, pg_drop_replication_slot() could fail. Avoid failure by adding a wait for the replication slot to become inactive. Reported-by: Hou Zhijie, as per buildfarm Reviewed-by: Hou Zhijie Discussion: https://postgr.es/m/OS0PR01MB571682316378379AA34854F694E9A%40OS0PR01MB5716.jpnprd01.prod.outlook.com Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/28ed5ecbe07121fd55d081e5be1f297a6177c779 Modified Files -------------- src/test/subscription/t/026_stats.pl | 8 ++++++++ 1 file changed, 8 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Stabilize subscription stats test. @ 2023-09-08 13:53 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Masahiko Sawada @ 2023-09-08 13:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize subscription stats test. The new test added by commit 68a59f9e9 disables the subscription and manually drops the associated replication slot. However, since disabling the subsubscription doesn't wait for a walsender to release the replication slot and exit, pg_drop_replication_slot() could fail. Avoid failure by adding a wait for the replication slot to become inactive. Reported-by: Hou Zhijie, as per buildfarm Reviewed-by: Hou Zhijie Discussion: https://postgr.es/m/OS0PR01MB571682316378379AA34854F694E9A%40OS0PR01MB5716.jpnprd01.prod.outlook.com Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1b95c8d85fa66c0ef63591b8064b023872a8f43c Modified Files -------------- src/test/subscription/t/026_stats.pl | 8 ++++++++ 1 file changed, 8 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Stabilize subscription stats test. @ 2023-09-08 13:53 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Masahiko Sawada @ 2023-09-08 13:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize subscription stats test. The new test added by commit 68a59f9e9 disables the subscription and manually drops the associated replication slot. However, since disabling the subsubscription doesn't wait for a walsender to release the replication slot and exit, pg_drop_replication_slot() could fail. Avoid failure by adding a wait for the replication slot to become inactive. Reported-by: Hou Zhijie, as per buildfarm Reviewed-by: Hou Zhijie Discussion: https://postgr.es/m/OS0PR01MB571682316378379AA34854F694E9A%40OS0PR01MB5716.jpnprd01.prod.outlook.com Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/461a7fad7c670037d5308d043609462e2ff83951 Modified Files -------------- src/test/subscription/t/026_stats.pl | 8 ++++++++ 1 file changed, 8 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-09-08 13:53 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-09-08 13:53 pgsql: Stabilize subscription stats test. Masahiko Sawada <msawada@postgresql.org> 2023-09-08 13:53 pgsql: Stabilize subscription stats test. Masahiko Sawada <msawada@postgresql.org> 2023-09-08 13:53 pgsql: Stabilize subscription stats test. Masahiko Sawada <msawada@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox