pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize subscription stats test.
Date: Fri, 08 Sep 2023 13:53:50 +0000
Message-ID: <E1qebvh-002xkV-R8@gemulon.postgresql.org> (raw)

Stabilize subscription stats test.

The new test added by commit 68a59f9e9 disables the subscription and
manually drops the associated replication slot. However, since
disabling the subsubscription doesn't wait for a walsender to release
the replication slot and exit, pg_drop_replication_slot() could
fail. Avoid failure by adding a wait for the replication slot to
become inactive.

Reported-by: Hou Zhijie, as per buildfarm
Reviewed-by: Hou Zhijie
Discussion: https://postgr.es/m/OS0PR01MB571682316378379AA34854F694E9A%40OS0PR01MB5716.jpnprd01.prod.outlook.com
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/461a7fad7c670037d5308d043609462e2ff83951

Modified Files
--------------
src/test/subscription/t/026_stats.pl | 8 ++++++++
1 file changed, 8 insertions(+)



view thread (3+ messages)

Message-ID: <E1qebvh-002xkV-R8@gemulon.postgresql.org>
Permalink:  ../E1qebvh-002xkV-R8@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qebvh-002xkV-R8@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Stabilize subscription stats test.
  In-Reply-To: <E1qebvh-002xkV-R8@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox