pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect logic in plan dependency recording
Date: Wed, 13 Sep 2023 23:28:11 +0000
Message-ID: <E1qgZHH-003h4X-4W@gemulon.postgresql.org> (raw)

Fix incorrect logic in plan dependency recording

Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency
on a function but mistakenly inverted the OidIsValid test.  This meant
that we'd record a dependency only when the function's Oid was
InvalidOid.  Clearly this was meant to *not* record the dependency in
that case.

50e17ad28 made this mistake first, then in v15 29f45e299 copied the same
mistake.

Reported-by: Tom Lane
Backpatch-through: 14, where 50e17ad28 first made this mistake
Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ee3a551e96c465f96de04dd1faf4e7bff8d25342

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1qgZHH-003h4X-4W@gemulon.postgresql.org>
Permalink:  ../E1qgZHH-003h4X-4W@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qgZHH-003h4X-4W@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix incorrect logic in plan dependency recording
  In-Reply-To: <E1qgZHH-003h4X-4W@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox