pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix incorrect logic in plan dependency recording 4+ messages / 1 participants [nested] [flat]
* pgsql: Fix incorrect logic in plan dependency recording @ 2023-09-13 23:28 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: David Rowley @ 2023-09-13 23:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect logic in plan dependency recording Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency on a function but mistakenly inverted the OidIsValid test. This meant that we'd record a dependency only when the function's Oid was InvalidOid. Clearly this was meant to *not* record the dependency in that case. 50e17ad28 made this mistake first, then in v15 29f45e299 copied the same mistake. Reported-by: Tom Lane Backpatch-through: 14, where 50e17ad28 first made this mistake Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ee3a551e96c465f96de04dd1faf4e7bff8d25342 Modified Files -------------- src/backend/optimizer/plan/setrefs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix incorrect logic in plan dependency recording @ 2023-09-13 23:28 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: David Rowley @ 2023-09-13 23:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect logic in plan dependency recording Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency on a function but mistakenly inverted the OidIsValid test. This meant that we'd record a dependency only when the function's Oid was InvalidOid. Clearly this was meant to *not* record the dependency in that case. 50e17ad28 made this mistake first, then in v15 29f45e299 copied the same mistake. Reported-by: Tom Lane Backpatch-through: 14, where 50e17ad28 first made this mistake Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1a6900e58ae2c61b84b516901985e405b9d457b7 Modified Files -------------- src/backend/optimizer/plan/setrefs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix incorrect logic in plan dependency recording @ 2023-09-13 23:28 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: David Rowley @ 2023-09-13 23:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect logic in plan dependency recording Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency on a function but mistakenly inverted the OidIsValid test. This meant that we'd record a dependency only when the function's Oid was InvalidOid. Clearly this was meant to *not* record the dependency in that case. 50e17ad28 made this mistake first, then in v15 29f45e299 copied the same mistake. Reported-by: Tom Lane Backpatch-through: 14, where 50e17ad28 first made this mistake Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/17a3f1c3475a4a31ea0af9c95efdccd07dd4247c Modified Files -------------- src/backend/optimizer/plan/setrefs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix incorrect logic in plan dependency recording @ 2023-09-13 23:29 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: David Rowley @ 2023-09-13 23:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect logic in plan dependency recording Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency on a function but mistakenly inverted the OidIsValid test. This meant that we'd record a dependency only when the function's Oid was InvalidOid. Clearly this was meant to *not* record the dependency in that case. 50e17ad28 made this mistake first, then in v15 29f45e299 copied the same mistake. Reported-by: Tom Lane Backpatch-through: 14, where 50e17ad28 first made this mistake Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6341cb0b02ae16d7bbb8b4e7ebabf80c551a685e Modified Files -------------- src/backend/optimizer/plan/setrefs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-09-13 23:29 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-09-13 23:28 pgsql: Fix incorrect logic in plan dependency recording David Rowley <drowley@postgresql.org> 2023-09-13 23:28 pgsql: Fix incorrect logic in plan dependency recording David Rowley <drowley@postgresql.org> 2023-09-13 23:28 pgsql: Fix incorrect logic in plan dependency recording David Rowley <drowley@postgresql.org> 2023-09-13 23:29 pgsql: Fix incorrect logic in plan dependency recording David Rowley <drowley@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox