pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix tracking of temp table relation extensions as writes
2+ messages / 1 participants
[nested] [flat]

* pgsql: Fix tracking of temp table relation extensions as writes
@ 2023-09-14 02:22 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2023-09-14 02:22 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix tracking of temp table relation extensions as writes

Karina figured out that I (Andres) confused BufferUsage.temp_blks_written with
BufferUsage.local_blks_written in fcdda1e4b5.

Tests in core PG can't easily test this, as BufferUsage is just used for
EXPLAIN (ANALYZE, BUFFERS) and pg_stat_statements. Thus this commit adds tests
for this to pg_stat_statements.

Reported-by: Karina Litskevich <litskevichkarina@gmail.com>
Author: Karina Litskevich <litskevichkarina@gmail.com>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CACiT8ibxXA6+0amGikbeFhm8B84XdQVo6D0Qfd1pQ1s8zpsnxQ@mail.gmail.com
Backpatch: 16-, where fcdda1e4b5 was merged

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7369798a83c883a6314b8a8ed6d3063c508de784

Modified Files
--------------
contrib/pg_stat_statements/expected/dml.out | 27 +++++++++++++++++++++++++++
contrib/pg_stat_statements/sql/dml.sql      | 19 +++++++++++++++++++
src/backend/storage/buffer/localbuf.c       |  2 +-
3 files changed, 47 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Fix tracking of temp table relation extensions as writes
@ 2023-09-14 02:22 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2023-09-14 02:22 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix tracking of temp table relation extensions as writes

Karina figured out that I (Andres) confused BufferUsage.temp_blks_written with
BufferUsage.local_blks_written in fcdda1e4b5.

Tests in core PG can't easily test this, as BufferUsage is just used for
EXPLAIN (ANALYZE, BUFFERS) and pg_stat_statements. Thus this commit adds tests
for this to pg_stat_statements.

Reported-by: Karina Litskevich <litskevichkarina@gmail.com>
Author: Karina Litskevich <litskevichkarina@gmail.com>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CACiT8ibxXA6+0amGikbeFhm8B84XdQVo6D0Qfd1pQ1s8zpsnxQ@mail.gmail.com
Backpatch: 16-, where fcdda1e4b5 was merged

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c4758649b4db7d0c4b681985d24cc3e1e938047d

Modified Files
--------------
contrib/pg_stat_statements/expected/dml.out | 27 +++++++++++++++++++++++++++
contrib/pg_stat_statements/sql/dml.sql      | 19 +++++++++++++++++++
src/backend/storage/buffer/localbuf.c       |  2 +-
3 files changed, 47 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-09-14 02:22 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14 02:22 pgsql: Fix tracking of temp table relation extensions as writes Andres Freund <andres@anarazel.de>
2023-09-14 02:22 pgsql: Fix tracking of temp table relation extensions as writes Andres Freund <andres@anarazel.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox