pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix tracking of temp table relation extensions as writes
Date: Thu, 14 Sep 2023 02:22:00 +0000
Message-ID: <E1qgbzT-003i9y-T9@gemulon.postgresql.org> (raw)

Fix tracking of temp table relation extensions as writes

Karina figured out that I (Andres) confused BufferUsage.temp_blks_written with
BufferUsage.local_blks_written in fcdda1e4b5.

Tests in core PG can't easily test this, as BufferUsage is just used for
EXPLAIN (ANALYZE, BUFFERS) and pg_stat_statements. Thus this commit adds tests
for this to pg_stat_statements.

Reported-by: Karina Litskevich <litskevichkarina@gmail.com>
Author: Karina Litskevich <litskevichkarina@gmail.com>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CACiT8ibxXA6+0amGikbeFhm8B84XdQVo6D0Qfd1pQ1s8zpsnxQ@mail.gmail.com
Backpatch: 16-, where fcdda1e4b5 was merged

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c4758649b4db7d0c4b681985d24cc3e1e938047d

Modified Files
--------------
contrib/pg_stat_statements/expected/dml.out | 27 +++++++++++++++++++++++++++
contrib/pg_stat_statements/sql/dml.sql      | 19 +++++++++++++++++++
src/backend/storage/buffer/localbuf.c       |  2 +-
3 files changed, 47 insertions(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1qgbzT-003i9y-T9@gemulon.postgresql.org>
Permalink:  ../E1qgbzT-003i9y-T9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qgbzT-003i9y-T9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix tracking of temp table relation extensions as writes
  In-Reply-To: <E1qgbzT-003i9y-T9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox