pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Flush logical slots to disk during a shutdown checkpoint if requ
Date: Thu, 14 Sep 2023 03:43:18 +0000
Message-ID: <E1qgdGA-003ibL-G3@gemulon.postgresql.org> (raw)

Flush logical slots to disk during a shutdown checkpoint if required.

It's entirely possible for a logical slot to have a confirmed_flush LSN
higher than the last value saved on disk while not being marked as dirty.
Currently, it is not a major problem but a later patch adding support for
the upgrade of slots relies on that value being properly flushed to disk.

It can also help avoid processing the same transactions again in some
boundary cases after the clean shutdown and restart.  Say, we process
some transactions for which we didn't send anything downstream (the
changes got filtered) but the confirm_flush LSN is updated due to
keepalives.  As we don't flush the latest value of confirm_flush LSN, it
may lead to processing the same changes again without this patch.

The approach taken by this patch has been suggested by Ashutosh Bapat.

Author: Vignesh C, Julien Rouhaud, Kuroda Hayato
Reviewed-by: Amit Kapila, Dilip Kumar, Michael Paquier, Ashutosh Bapat, Peter Smith, Hou Zhijie
Discussion: http://postgr.es/m/CAA4eK1JzJagMmb_E8D4au=GYQkxox0AfNBm1FbP7sy7t4YWXPQ@mail.gmail.com
Discussion: http://postgr.es/m/TYAPR01MB58664C81887B3AF2EB6B16E3F5939@TYAPR01MB5866.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e0b2eed047df9045664da6f724cb42c10f8b12f0

Modified Files
--------------
src/backend/access/transam/xlog.c                  |   2 +-
src/backend/replication/slot.c                     |  37 +++++++-
src/include/replication/slot.h                     |   9 +-
src/test/recovery/meson.build                      |   1 +
.../recovery/t/038_save_logical_slots_shutdown.pl  | 102 +++++++++++++++++++++
5 files changed, 145 insertions(+), 6 deletions(-)



Message-ID: <E1qgdGA-003ibL-G3@gemulon.postgresql.org>
Permalink:  ../E1qgdGA-003ibL-G3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qgdGA-003ibL-G3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Flush logical slots to disk during a shutdown checkpoint if requ
  In-Reply-To: <E1qgdGA-003ibL-G3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox