pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix get_expr_result_type() to find field names for RECORD Consts
Date: Fri, 15 Sep 2023 21:02:06 +0000
Message-ID: <E1qhFx0-0042tj-J5@gemulon.postgresql.org> (raw)

Fix get_expr_result_type() to find field names for RECORD Consts.

This is a back-patch of commit d57534740 ("Fix EXPLAIN of SEARCH
BREADTH FIRST with a constant initial value") into pre-v14 branches.
At the time I'd thought it was not needed in branches that lack the
SEARCH/CYCLE feature, but that was just a failure of imagination.
It's possible to demonstrate "record type has not been registered"
failures in older branches too, during deparsing of views that contain
references to fields of composite constants.

Back-patch only the code changes, as the test cases added by d57534740
all require SEARCH/CYCLE syntax.  A suitable test case will be added
in the upcoming fix for bug #18077.

Discussion: https://postgr.es/m/17644-3bd1f3036d6d7a16@postgresql.org
Discussion: https://postgr.es/m/3607145.1694803130@sss.pgh.pa.us

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/59bc0dfe44a640c88adecc5b97def54b7355abcf

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |  3 ++-
src/backend/utils/fmgr/funcapi.c  | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+), 1 deletion(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1qhFx0-0042tj-J5@gemulon.postgresql.org>
Permalink:  ../E1qhFx0-0042tj-J5@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qhFx0-0042tj-J5@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix get_expr_result_type() to find field names for RECORD Consts
  In-Reply-To: <E1qhFx0-0042tj-J5@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox