pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't crash if cursor_to_xmlschema is used on a non-data-returni
Date: Mon, 18 Sep 2023 18:28:33 +0000
Message-ID: <E1qiIz3-004bfE-3b@gemulon.postgresql.org> (raw)

Don't crash if cursor_to_xmlschema is used on a non-data-returning Portal.

cursor_to_xmlschema() assumed that any Portal must have a tupDesc,
which is not so.  Add a defensive check.

It's plausible that this mistake occurred because of the rather
poorly chosen name of the lookup function SPI_cursor_find(),
which in such cases is returning something that isn't very much
like a cursor.  Add some documentation to try to forestall future
errors of the same ilk.

Report and patch by Boyu Yang (docs changes by me).  Back-patch
to all supported branches.

Discussion: https://postgr.es/m/dd343010-c637-434c-a8cb-418f53bda3b8.yangboyu.yby@alibaba-inc.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/95f54f0d034eb69349f9134a01441a3cdd311419

Modified Files
--------------
doc/src/sgml/spi.sgml       | 13 +++++++++++++
src/backend/utils/adt/xml.c |  4 ++++
2 files changed, 17 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1qiIz3-004bfE-3b@gemulon.postgresql.org>
Permalink:  ../E1qiIz3-004bfE-3b@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qiIz3-004bfE-3b@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't crash if cursor_to_xmlschema is used on a non-data-returni
  In-Reply-To: <E1qiIz3-004bfE-3b@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox