pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Update comment about set_join_pathlist_hook().
Date: Thu, 21 Sep 2023 10:58:05 +0000
Message-ID: <E1qjHNk-0056pw-SK@gemulon.postgresql.org> (raw)

Update comment about set_join_pathlist_hook().

The comment introduced by commit e7cb7ee14 was a bit too terse, which
could lead to extensions doing different things within the hook function
than we intend to allow.  Extend the comment to explain what they can do
within the hook function.

Back-patch to all supported branches.

In passing, I rephrased a nearby comment that I recently added to the
back branches.

Reviewed by David Rowley and Andrei Lepikhov.

Discussion: https://postgr.es/m/CAPmGK15SBPA1nr3Aqsdm%2BYyS-ay0Ayo2BRYQ8_A2To9eLqwopQ%40mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a3a66d3ff18c5a4b49a9fbebce55aa83711953f6

Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1qjHNk-0056pw-SK@gemulon.postgresql.org>
Permalink:  ../E1qjHNk-0056pw-SK@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qjHNk-0056pw-SK@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Update comment about set_join_pathlist_hook().
  In-Reply-To: <E1qjHNk-0056pw-SK@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox