pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid using internal test methods in SSL tests
Date: Fri, 22 Sep 2023 11:40:54 +0000
Message-ID: <E1qjeWk-005IS5-3V@gemulon.postgresql.org> (raw)

Avoid using internal test methods in SSL tests

The SSL tests for pg_ctl restart with an incorrect key passphrase used
the internal _update_pid method to set the pidfile after running pg_ctl
manually instead of using the supplied ->restart method. This refactors
the ->restart method to accept a fail_ok parameter like how ->start and
->stop does, and changes the SSL tests to use this instead. This removes
the need to call internal test module functions.

Reviewed-by: Melih Mutlu <m.melihmutlu@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/F81643C4-D7B8-4C6B-AF18-B73839966279@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/33774978c78175095da9e6c276e8bcdb177725f8

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 31 +++++++++++++++++++++++--------
src/test/ssl/t/001_ssltests.pl           | 23 +++++++++--------------
2 files changed, 32 insertions(+), 22 deletions(-)



Message-ID: <E1qjeWk-005IS5-3V@gemulon.postgresql.org>
Permalink:  ../E1qjeWk-005IS5-3V@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qjeWk-005IS5-3V@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid using internal test methods in SSL tests
  In-Reply-To: <E1qjeWk-005IS5-3V@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox