pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't use Perl pack('Q') in 039_end_of_wal.pl.
Date: Sat, 23 Sep 2023 02:28:13 +0000
Message-ID: <E1qjsNQ-005P5s-L6@gemulon.postgresql.org> (raw)

Don't use Perl pack('Q') in 039_end_of_wal.pl.

'Q' for 64 bit integers turns out not to work on 32 bit Perl, as
revealed by the build farm.  Use 'II' instead, and deal with endianness.

Back-patch to 12, like bae868ca.

Discussion: https://postgr.es/m/ZQ4r1vHcryBsSi_V%40paquier.xyz

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/21b4c3ca0b22761eccdc55c265a12c6296c10068

Modified Files
--------------
src/test/recovery/t/039_end_of_wal.pl | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1qjsNQ-005P5s-L6@gemulon.postgresql.org>
Permalink:  ../E1qjsNQ-005P5s-L6@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qjsNQ-005P5s-L6@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't use Perl pack('Q') in 039_end_of_wal.pl.
  In-Reply-To: <E1qjsNQ-005P5s-L6@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox