pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: vacuumdb: Fix excluding multiple schemas with -N
Date: Mon, 25 Sep 2023 14:05:29 +0000
Message-ID: <E1qkmDI-005sEd-MW@gemulon.postgresql.org> (raw)

vacuumdb: Fix excluding multiple schemas with -N

When specifying multiple schemas to exclude with -N parameters, none
of the schemas are actually excluded (a single -N worked as expected).
This fixes the catalog query to handle multiple exclusions and adds a
test for this case.

Backpatch to v16 where this was introduced.

Author: Nathan Bossart <nathandbossart@gmail.com>
Author: Kuwamura Masaki <kuwamura@db.is.i.nagoya-u.ac.jp>
Reported-by: Kuwamura Masaki <kuwamura@db.is.i.nagoya-u.ac.jp>
Discussion: https://postgr.es/m/CAMyC8qp9mXPQd5D6s6CJxvmignsbTqGZwDDB6VYJOn1A8WG38w@mail.gmail.com
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fb56a181175bba03a6d4f82cd3c07ec5511ce545

Modified Files
--------------
src/bin/scripts/t/100_vacuumdb.pl | 15 ++++++++++++++-
src/bin/scripts/vacuumdb.c        | 26 ++++++++++++++++----------
2 files changed, 30 insertions(+), 11 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1qkmDI-005sEd-MW@gemulon.postgresql.org>
Permalink:  ../E1qkmDI-005sEd-MW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qkmDI-005sEd-MW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: vacuumdb: Fix excluding multiple schemas with -N
  In-Reply-To: <E1qkmDI-005sEd-MW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox