pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: unaccent: Tweak value of PYTHON when building without Python sup
Date: Wed, 27 Sep 2023 05:42:17 +0000
Message-ID: <E1qlNJR-006DsI-OV@gemulon.postgresql.org> (raw)

unaccent: Tweak value of PYTHON when building without Python support

As coded, the module's Makefile would fail to set a value for PYTHON as
it checked if the variable is defined.  When compiling without
--with-python, PYTHON is defined and set to an empty value, so the
existing check is not able to do its work.

This commit switches the rule to check if the value is empty rather than
defined, allowing the generation of unaccent.rules even if --with-python
is not used as long as "python" exists.  BISON and FLEX do the same in
pgxs.mk, for instance.

Thinko in f85a485f89e2.

Author: Japin Li
Discussion: https://postgr.es/m/MEYP282MB1669F86C0DC7B4DC48489CB0B6C3A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6fc3a138b1e8049a73e48d4b0f1031a1e6e7b8c6

Modified Files
--------------
contrib/unaccent/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1qlNJR-006DsI-OV@gemulon.postgresql.org>
Permalink:  ../E1qlNJR-006DsI-OV@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qlNJR-006DsI-OV@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: unaccent: Tweak value of PYTHON when building without Python sup
  In-Reply-To: <E1qlNJR-006DsI-OV@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox