pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move tracking of in_streaming to PGOutputData
Date: Thu, 28 Sep 2023 00:34:19 +0000
Message-ID: <E1qleyx-006Mqk-8A@gemulon.postgresql.org> (raw)

Move tracking of in_streaming to PGOutputData

"in_streaming" is a flag used to track if an instance of pgoutput is
streaming changes.  When pgoutput is started, the flag was always reset,
switched it back and forth in the stream start/stop callbacks.

Before this commit, it was a global variable, which is confusing as it
is actually attached to a state of PGOutputData.  Per my analysis, using
a global variable did not lead to an active bug like in 54ccfd65868c,
but it makes the code more consistent.  Note that we cannot backpatch
this change anyway as it requires the addition of a new field to
PGOutputData, exposed in pgoutput.h.

Author: Hou Zhijie
Reviewed-by: Amit Kapila, Michael Paquier, Peter Smith
Discussion: https://postgr.es/m/OS0PR01MB571690EF24F51F51EFFCBB0E94FAA@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9210afd3bcd65feccb883ace4ed6dcef6a684585

Modified Files
--------------
src/backend/replication/pgoutput/pgoutput.c | 34 +++++++++++++++--------------
src/include/replication/pgoutput.h          |  3 +++
2 files changed, 21 insertions(+), 16 deletions(-)



Message-ID: <E1qleyx-006Mqk-8A@gemulon.postgresql.org>
Permalink:  ../E1qleyx-006Mqk-8A@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qleyx-006Mqk-8A@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Move tracking of in_streaming to PGOutputData
  In-Reply-To: <E1qleyx-006Mqk-8A@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox