pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove environment sensitivity in pl/tcl regression test.
Date: Sat, 30 Sep 2023 00:21:19 +0000
Message-ID: <E1qmNjT-006iLZ-Pi@gemulon.postgresql.org> (raw)

Remove environment sensitivity in pl/tcl regression test.

Add "-gmt 1" to our test invocations of the Tcl "clock" command,
so that they do not consult the timezone environment.  While it
doesn't really matter which timezone is used here, it does
matter that the command not fall over entirely.  We've now
discovered that at least on FreeBSD, "clock scan" will fail if
/etc/localtime is missing.  It seems worth making the test
insensitive to that.

Per Tomas Vondras' buildfarm animal dikkop.  Thanks to
Thomas Munro for the diagnosis.

Discussion: https://postgr.es/m/316d304a-1dcd-cea1-3d6c-27f794727a06@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f02154652d1a83d80f4bee93b58ecdbd8c33378b

Modified Files
--------------
src/pl/tcl/expected/pltcl_setup.out | 2 +-
src/pl/tcl/sql/pltcl_setup.sql      | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



view thread (7+ messages)

Message-ID: <E1qmNjT-006iLZ-Pi@gemulon.postgresql.org>
Permalink:  ../E1qmNjT-006iLZ-Pi@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qmNjT-006iLZ-Pi@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove environment sensitivity in pl/tcl regression test.
  In-Reply-To: <E1qmNjT-006iLZ-Pi@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox