pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix EvalPlanQual rechecking during MERGE.
Date: Sat, 30 Sep 2023 09:57:19 +0000
Message-ID: <E1qmWit-006mfU-Kd@gemulon.postgresql.org> (raw)

Fix EvalPlanQual rechecking during MERGE.

Under some circumstances, concurrent MERGE operations could lead to
inconsistent results, that varied according the plan chosen. This was
caused by a lack of rowmarks on the source relation, which meant that
EvalPlanQual rechecking was not guaranteed to return the same source
tuples when re-running the join query.

Fix by ensuring that preprocess_rowmarks() sets up PlanRowMarks for
all non-target relations used in MERGE, in the same way that it does
for UPDATE and DELETE.

Per bug #18103. Back-patch to v15, where MERGE was introduced.

Dean Rasheed, reviewed by Richard Guo.

Discussion: https://postgr.es/m/18103-c4386baab8e355e3%40postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3c1a1af91d9504e4ce0319f48e83f7c2d5765969

Modified Files
--------------
src/backend/executor/README                |  12 +--
src/backend/executor/nodeModifyTable.c     |   6 +-
src/backend/optimizer/plan/planner.c       |   5 +-
src/include/nodes/execnodes.h              |   4 +-
src/include/nodes/plannodes.h              |   4 +-
src/test/isolation/expected/merge-join.out | 148 +++++++++++++++++++++++++++++
src/test/isolation/isolation_schedule      |   1 +
src/test/isolation/specs/merge-join.spec   |  45 +++++++++
src/test/regress/expected/merge.out        |   8 +-
src/test/regress/expected/with.out         |  42 ++++----
10 files changed, 237 insertions(+), 38 deletions(-)



view thread (3+ messages)

Message-ID: <E1qmWit-006mfU-Kd@gemulon.postgresql.org>
Permalink:  ../E1qmWit-006mfU-Kd@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qmWit-006mfU-Kd@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dean.a.rasheed@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix EvalPlanQual rechecking during MERGE.
  In-Reply-To: <E1qmWit-006mfU-Kd@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox