pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix briefly showing old progress stats for ANALYZE on inherited
Date: Sat, 30 Sep 2023 14:17:31 +0000
Message-ID: <E1qmamh-006oP5-Q8@gemulon.postgresql.org> (raw)

Fix briefly showing old progress stats for ANALYZE on inherited tables.

ANALYZE on a table with inheritance children analyzes all the child
tables in a loop. When stepping to next child table, it updated the
child rel ID value in the command progress stats, but did not reset
the 'sample_blks_total' and 'sample_blks_scanned' counters.
acquire_sample_rows() updates 'sample_blks_total' as soon as the scan
starts and 'sample_blks_scanned' after processing the first block, but
until then, pg_stat_progress_analyze would display a bogus combination
of the new child table relid with old counter values from the
previously processed child table. Fix by resetting 'sample_blks_total'
and 'sample_blks_scanned' to zero at the same time that
'current_child_table_relid' is updated.

Backpatch to v13, where pg_stat_progress_analyze view was introduced.

Reported-by: Justin Pryzby
Discussion: https://www.postgresql.org/message-id/20230122162345.GP13860%40telsasoft.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ae245664830219bab2e2ada11d2379875f4501a

Modified Files
--------------
src/backend/commands/analyze.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1qmamh-006oP5-Q8@gemulon.postgresql.org>
Permalink:  ../E1qmamh-006oP5-Q8@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qmamh-006oP5-Q8@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix briefly showing old progress stats for ANALYZE on inherited
  In-Reply-To: <E1qmamh-006oP5-Q8@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox