pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix omission of column-level privileges in selective pg_restore.
Date: Mon, 02 Oct 2023 17:28:29 +0000
Message-ID: <E1qnMib-007AGH-1v@gemulon.postgresql.org> (raw)

Fix omission of column-level privileges in selective pg_restore.

In a selective restore, ACLs for a table should be dumped if the
table is selected to be dumped.  However, if the table has both
table-level and column-level ACLs, only the table-level ACL was
restored.  This happened because _tocEntryRequired assumed that
an ACL could have only one dependency (the one on its table),
and punted if there was more than one.  But since commit ea9125304,
column-level ACLs also depend on the table-level ACL if any, to
ensure correct ordering in parallel restores.  To fix, adjust the
logic in _tocEntryRequired to ignore dependencies on ACLs.

I extended a test case in 002_pg_dump.pl so that it purports to
test for this; but in fact the test passes even without the fix.
That's because this bug only manifests during a selective restore,
while the scenarios 002_pg_dump.pl tests include only selective dumps.
Perhaps somebody would like to extend the script so that it can test
scenarios including selective restore, but I'm not touching that.

Euler Taveira and Tom Lane, per report from Kong Man.
Back-patch to all supported branches.

Discussion: https://postgr.es/m/DM4PR11MB73976902DBBA10B1D652F9498B06A@DM4PR11MB7397.namprd11.prod.outlook.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c02f29758bc8ccfb77e6bc84b248283ce87efb8f

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 24 +++++++++++++++++++++---
src/bin/pg_dump/t/002_pg_dump.pl     |  8 +++++---
2 files changed, 26 insertions(+), 6 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1qnMib-007AGH-1v@gemulon.postgresql.org>
Permalink:  ../E1qnMib-007AGH-1v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qnMib-007AGH-1v@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix omission of column-level privileges in selective pg_restore.
  In-Reply-To: <E1qnMib-007AGH-1v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox