pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tidy-up some appendStringInfo*() usages
Date: Tue, 03 Oct 2023 04:10:15 +0000
Message-ID: <E1qnWjf-007EPl-VY@gemulon.postgresql.org> (raw)

Tidy-up some appendStringInfo*() usages

Make a few newish calls to appendStringInfo() which have no special
formatting use appendStringInfoString() instead.  Also, adjust usages of
appendStringInfoString() which only append a string containing a single
character to make use of appendStringInfoChar() instead.

This makes the code marginally faster, but primarily this change is so
we use the StringInfo type as it was intended to be used.

Discussion: https://postgr.es/m/CAApHDvpXKQmL+r=VDNS98upqhr9yGBhv2Jw3GBFFk_wKHcB39A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2075ba9dc9af8833b1147996c15246e44a1e4fab

Modified Files
--------------
src/backend/access/rmgrdesc/heapdesc.c       | 6 +++---
src/backend/access/rmgrdesc/nbtdesc.c        | 2 +-
src/backend/access/rmgrdesc/rmgrdesc_utils.c | 2 +-
src/backend/access/transam/xlogbackup.c      | 2 +-
src/backend/replication/slot.c               | 2 +-
src/backend/utils/adt/ruleutils.c            | 4 ++--
src/test/regress/pg_regress.c                | 4 ++--
7 files changed, 11 insertions(+), 11 deletions(-)



Message-ID: <E1qnWjf-007EPl-VY@gemulon.postgresql.org>
Permalink:  ../E1qnWjf-007EPl-VY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qnWjf-007EPl-VY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Tidy-up some appendStringInfo*() usages
  In-Reply-To: <E1qnWjf-007EPl-VY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox