pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: In basebackup.c, refactor to create read_file_data_into_buffer.
Date: Tue, 03 Oct 2023 15:01:18 +0000
Message-ID: <E1qngti-007JiS-ND@gemulon.postgresql.org> (raw)

In basebackup.c, refactor to create read_file_data_into_buffer.

This further reduces the length and complexity of sendFile(),
hopefully make it easier to understand and modify. In addition
to moving some logic into a new function, I took this opportunity
to make a few slight adjustments to sendFile() itself, including
renaming the 'len' variable to 'bytes_done', since we use it to represent
the number of bytes we've already handled so far, not the total
length of the file.

Patch by me, reviewed by David Steele.

Discussion: http://postgr.es/m/CA+TgmoYt5jXH4U6cu1dm9Oe2FTn1aae6hBNhZzJJjyjbE_zYig@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c2ba3fdea5938dff96ca32ed7a4a83c8ff5f188d

Modified Files
--------------
src/backend/backup/basebackup.c | 231 +++++++++++++++++++++++-----------------
1 file changed, 133 insertions(+), 98 deletions(-)



view thread (2+ messages)

Message-ID: <E1qngti-007JiS-ND@gemulon.postgresql.org>
Permalink:  ../E1qngti-007JiS-ND@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qngti-007JiS-ND@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: In basebackup.c, refactor to create read_file_data_into_buffer.
  In-Reply-To: <E1qngti-007JiS-ND@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox