pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN
2+ messages / 1 participants
[nested] [flat]

* pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN
@ 2023-10-06 01:03  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2023-10-06 01:03 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN

A bgworker can spawn parallel workers of its own when executing queries,
and if the worker uses BGWORKER_BYPASS_ALLOWCONN while the database it
is connected to does not allow connections, a parallel worker would fail
to startup.  In the case of this module, the step checking for the
presence of the schema to create was spawning a worker, failing the last
test introduced by 991bb0f9653c.

This issue could be reproduced with debug_parallel_query = 'regress',
for example.

Per buildfarm member crake.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd4d93d269c02081958e4c0c214f1d82186e5689

Modified Files
--------------
src/test/modules/worker_spi/worker_spi.c | 9 +++++++++
1 file changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ROLELOGINCHECK
@ 2023-10-16 04:48  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2023-10-16 04:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

worker_spi: Fix test failure with BGWORKER_BYPASS_ROLELOGINCHECK

This is a consequence of 4817da51f69a that has bumped up
max_worker_processes, where now the last worker started by the test
would be able to start by itself a parallel worker because there are
more slots available.  This did not show up before as the number of
bgworkers reached exactly 8, as known as the previous limit, at the end
of the test.

Per report from buildfarm member crake, reproducible with
debug_parallel_query = regress in the same fashion as fd4d93d269c0.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4922173010f102a7d56af7c97bd303b95b3f6eff

Modified Files
--------------
src/test/modules/worker_spi/worker_spi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-10-16 04:48 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-10-06 01:03 pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN Michael Paquier <michael@paquier.xyz>
2023-10-16 04:48 pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ROLELOGINCHECK Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox