pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN
Date: Fri, 06 Oct 2023 01:03:25 +0000
Message-ID: <E1qoZFU-000FxV-Fz@gemulon.postgresql.org> (raw)

worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN

A bgworker can spawn parallel workers of its own when executing queries,
and if the worker uses BGWORKER_BYPASS_ALLOWCONN while the database it
is connected to does not allow connections, a parallel worker would fail
to startup.  In the case of this module, the step checking for the
presence of the schema to create was spawning a worker, failing the last
test introduced by 991bb0f9653c.

This issue could be reproduced with debug_parallel_query = 'regress',
for example.

Per buildfarm member crake.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd4d93d269c02081958e4c0c214f1d82186e5689

Modified Files
--------------
src/test/modules/worker_spi/worker_spi.c | 9 +++++++++
1 file changed, 9 insertions(+)



view thread (2+ messages)  latest in thread

Message-ID: <E1qoZFU-000FxV-Fz@gemulon.postgresql.org>
Permalink:  ../E1qoZFU-000FxV-Fz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qoZFU-000FxV-Fz@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN
  In-Reply-To: <E1qoZFU-000FxV-Fz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox