pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove debug_print_rel and replace usages with pprint
Date: Mon, 09 Oct 2023 02:54:36 +0000
Message-ID: <E1qpgPj-000j8w-Nn@gemulon.postgresql.org> (raw)

Remove debug_print_rel and replace usages with pprint

Going by c4a1933b4, b33ef397a and 05893712c (to name just a few), it seems
that maintaining debug_print_rel() is often forgotten.  In the case of
c4a1933b4, it was several years before anyone noticed that a path type
was not handled by debug_print_rel().  (debug_print_rel() is only
compiled when building with OPTIMIZER_DEBUG).

After a quick survey on the pgsql-hackers mailing list, nobody came
forward to admit that they use OPTIMIZER_DEBUG.  So to prevent any future
maintenance neglect, let's just remove debug_print_rel() and have
OPTIMIZER_DEBUG make use of pprint() instead (as suggested by Tom Lane).
If anyone wants to come forward to claim they make use of
OPTIMIZER_DEBUG in a way that they need debug_print_rel() then they have
around 10 months remaining in the v17 cycle where we could revert this.
If nobody comes forward in that time, then we can likely safely declare
debug_print_rel() as not worth keeping.

Discussion: https://postgr.es/m/CAApHDvoCdjo8Cu2zEZF4-AxWG-90S+pYXAnoDDa9J3xH-OrczQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/77db132637661f6e01497959128fb650330552b4

Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 328 +---------------------------------
src/include/optimizer/paths.h         |   4 -
2 files changed, 3 insertions(+), 329 deletions(-)



Message-ID: <E1qpgPj-000j8w-Nn@gemulon.postgresql.org>
Permalink:  ../E1qpgPj-000j8w-Nn@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qpgPj-000j8w-Nn@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove debug_print_rel and replace usages with pprint
  In-Reply-To: <E1qpgPj-000j8w-Nn@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox