From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename StartBackgroundWorker() to BackgroundWorkerMain().
Date: Mon, 09 Oct 2023 08:52:41 +0000
Message-ID: <E1qpm0G-000lfj-Pb@gemulon.postgresql.org> (raw)
Rename StartBackgroundWorker() to BackgroundWorkerMain().
The comment claimed that it is "called from postmaster", but it is
actually called in the child process, pretty early in the process
initialization. I guess you could interpret "called from postmaster"
to mean that, but it seems wrong to me. Rename the function to be
consistent with other functions with similar role.
Reviewed-by: Thomas Munro
Discussion: https://www.postgresql.org/message-id/4f95c1fc-ad3c-7974-3a8c-6faa3931804c@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/637109d13ab2684aa7ad4e893137e7487b5e8490
Modified Files
--------------
src/backend/postmaster/bgworker.c | 7 ++-----
src/backend/postmaster/postmaster.c | 4 ++--
src/include/postmaster/bgworker_internals.h | 4 ++--
3 files changed, 6 insertions(+), 9 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rename StartBackgroundWorker() to BackgroundWorkerMain().
In-Reply-To: <E1qpm0G-000lfj-Pb@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox