pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Optimize various aggregate deserialization functions"
Date: Tue, 10 Oct 2023 01:17:27 +0000
Message-ID: <E1qq1NG-000rk1-F4@gemulon.postgresql.org> (raw)

Revert "Optimize various aggregate deserialization functions"

This reverts commit 608fd198def5390c3490bfe903730207dfd8eeb4.

On 2nd thoughts, the StringInfo API requires that strings are NUL
terminated and pointing directly to the data in a bytea Datum isn't NUL
terminated.

Discussion: https://postgr.es/m/CAApHDvorfO3iBZ=xpiZvp3uHtJVLyFaPBSvcAhAq2HPLnaNSwQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4f3b56eea23554e1756a26080db273156f23f4f2

Modified Files
--------------
src/backend/utils/adt/array_userfuncs.c | 24 ++++++++---------
src/backend/utils/adt/numeric.c         | 48 ++++++++++++++++-----------------
src/backend/utils/adt/varlena.c         | 12 ++++-----
3 files changed, 42 insertions(+), 42 deletions(-)



Message-ID: <E1qq1NG-000rk1-F4@gemulon.postgresql.org>
Permalink:  ../E1qq1NG-000rk1-F4@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qq1NG-000rk1-F4@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "Optimize various aggregate deserialization functions"
  In-Reply-To: <E1qq1NG-000rk1-F4@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox