pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_resetwal: Corrections around -c option
Date: Tue, 10 Oct 2023 07:05:54 +0000
Message-ID: <E1qq6oT-000uM6-Tt@gemulon.postgresql.org> (raw)

pg_resetwal: Corrections around -c option

The present pg_resetwal code hardcodes the minimum value for -c as 2,
which is FrozenTransactionId, but it's not clear why that is allowed.
After some research, it was probably a mistake in the original patch.
Change it to FirstNormalTransactionId, which matches other xid-related
options in pg_resetwal.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/d09f0e91-8757-642b-1a92-da9a52f5589a%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e3679bc1c31add8fa29a9dedd10fe6c563efde79

Modified Files
--------------
src/bin/pg_resetwal/pg_resetwal.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)



Message-ID: <E1qq6oT-000uM6-Tt@gemulon.postgresql.org>
Permalink:  ../E1qq6oT-000uM6-Tt@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qq6oT-000uM6-Tt@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_resetwal: Corrections around -c option
  In-Reply-To: <E1qq6oT-000uM6-Tt@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox