pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. 6+ messages / 1 participants [nested] [flat]
* pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. @ 2023-10-14 22:55 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2023-10-14 22:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't spuriously report FD_SETSIZE exhaustion on Windows. Starting on 2023-08-03, this intermittently terminated a "pgbench -C" test in CI. It could affect a high-client-count "pgbench" without "-C". While parallel reindexdb and vacuumdb reach the same problematic check, sufficient client count and/or connection turnover is less plausible for them. Given the lack of examples from the buildfarm or from manual builds, reproducing this must entail rare operating system configurations. Also correct the associated error message, which was wrong for non-Windows. Back-patch to v12, where the pgbench check first appeared. While v11 vacuumdb has the problematic check, reaching it with typical vacuumdb usage is implausible. Reviewed by Thomas Munro. Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/90ebcc32d9829204bfd15db82ece3aacd84f40d6 Modified Files -------------- src/bin/pgbench/pgbench.c | 19 ++++++++++++++----- src/fe_utils/parallel_slot.c | 37 +++++++++++++++++++++++++++++++++++-- 2 files changed, 49 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. @ 2023-10-14 22:55 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2023-10-14 22:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't spuriously report FD_SETSIZE exhaustion on Windows. Starting on 2023-08-03, this intermittently terminated a "pgbench -C" test in CI. It could affect a high-client-count "pgbench" without "-C". While parallel reindexdb and vacuumdb reach the same problematic check, sufficient client count and/or connection turnover is less plausible for them. Given the lack of examples from the buildfarm or from manual builds, reproducing this must entail rare operating system configurations. Also correct the associated error message, which was wrong for non-Windows. Back-patch to v12, where the pgbench check first appeared. While v11 vacuumdb has the problematic check, reaching it with typical vacuumdb usage is implausible. Reviewed by Thomas Munro. Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/06ff064842832187fce7474e866010d2764a066a Modified Files -------------- src/bin/pgbench/pgbench.c | 19 ++++++++++++++----- src/fe_utils/parallel_slot.c | 37 +++++++++++++++++++++++++++++++++++-- 2 files changed, 49 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. @ 2023-10-14 22:55 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2023-10-14 22:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't spuriously report FD_SETSIZE exhaustion on Windows. Starting on 2023-08-03, this intermittently terminated a "pgbench -C" test in CI. It could affect a high-client-count "pgbench" without "-C". While parallel reindexdb and vacuumdb reach the same problematic check, sufficient client count and/or connection turnover is less plausible for them. Given the lack of examples from the buildfarm or from manual builds, reproducing this must entail rare operating system configurations. Also correct the associated error message, which was wrong for non-Windows. Back-patch to v12, where the pgbench check first appeared. While v11 vacuumdb has the problematic check, reaching it with typical vacuumdb usage is implausible. Reviewed by Thomas Munro. Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1102f4ece30ed734ca2193fedac74395490aee99 Modified Files -------------- src/bin/pgbench/pgbench.c | 19 ++++++++++++++----- src/fe_utils/parallel_slot.c | 37 +++++++++++++++++++++++++++++++++++-- 2 files changed, 49 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. @ 2023-10-14 22:55 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2023-10-14 22:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't spuriously report FD_SETSIZE exhaustion on Windows. Starting on 2023-08-03, this intermittently terminated a "pgbench -C" test in CI. It could affect a high-client-count "pgbench" without "-C". While parallel reindexdb and vacuumdb reach the same problematic check, sufficient client count and/or connection turnover is less plausible for them. Given the lack of examples from the buildfarm or from manual builds, reproducing this must entail rare operating system configurations. Also correct the associated error message, which was wrong for non-Windows. Back-patch to v12, where the pgbench check first appeared. While v11 vacuumdb has the problematic check, reaching it with typical vacuumdb usage is implausible. Reviewed by Thomas Munro. Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0df88a68643bf36f30c69060073356e2a5388457 Modified Files -------------- src/bin/pgbench/pgbench.c | 17 ++++++++++++----- src/fe_utils/parallel_slot.c | 33 +++++++++++++++++++++++++++++++-- 2 files changed, 43 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. @ 2023-10-14 22:55 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2023-10-14 22:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't spuriously report FD_SETSIZE exhaustion on Windows. Starting on 2023-08-03, this intermittently terminated a "pgbench -C" test in CI. It could affect a high-client-count "pgbench" without "-C". While parallel reindexdb and vacuumdb reach the same problematic check, sufficient client count and/or connection turnover is less plausible for them. Given the lack of examples from the buildfarm or from manual builds, reproducing this must entail rare operating system configurations. Also correct the associated error message, which was wrong for non-Windows. Back-patch to v12, where the pgbench check first appeared. While v11 vacuumdb has the problematic check, reaching it with typical vacuumdb usage is implausible. Reviewed by Thomas Munro. Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3895e9153e29af66b038cf17756b4307fa967718 Modified Files -------------- src/bin/pgbench/pgbench.c | 17 ++++++++++++----- src/bin/scripts/scripts_parallel.c | 34 +++++++++++++++++++++++++++++----- 2 files changed, 41 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. @ 2023-10-14 22:55 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2023-10-14 22:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't spuriously report FD_SETSIZE exhaustion on Windows. Starting on 2023-08-03, this intermittently terminated a "pgbench -C" test in CI. It could affect a high-client-count "pgbench" without "-C". While parallel reindexdb and vacuumdb reach the same problematic check, sufficient client count and/or connection turnover is less plausible for them. Given the lack of examples from the buildfarm or from manual builds, reproducing this must entail rare operating system configurations. Also correct the associated error message, which was wrong for non-Windows. Back-patch to v12, where the pgbench check first appeared. While v11 vacuumdb has the problematic check, reaching it with typical vacuumdb usage is implausible. Reviewed by Thomas Munro. Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/73cda80a30a552c718f272379476a63d75327fda Modified Files -------------- src/bin/pgbench/pgbench.c | 19 ++++++++++++++----- src/bin/scripts/vacuumdb.c | 34 +++++++++++++++++++++++++++++----- 2 files changed, 43 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-10-14 22:55 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-10-14 22:55 pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. Noah Misch <noah@leadboat.com> 2023-10-14 22:55 pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. Noah Misch <noah@leadboat.com> 2023-10-14 22:55 pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. Noah Misch <noah@leadboat.com> 2023-10-14 22:55 pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. Noah Misch <noah@leadboat.com> 2023-10-14 22:55 pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. Noah Misch <noah@leadboat.com> 2023-10-14 22:55 pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox