pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.
Date: Sat, 14 Oct 2023 22:55:52 +0000
Message-ID: <E1qrnXz-000aIT-Jq@gemulon.postgresql.org> (raw)

Don't spuriously report FD_SETSIZE exhaustion on Windows.

Starting on 2023-08-03, this intermittently terminated a "pgbench -C"
test in CI.  It could affect a high-client-count "pgbench" without "-C".
While parallel reindexdb and vacuumdb reach the same problematic check,
sufficient client count and/or connection turnover is less plausible for
them.  Given the lack of examples from the buildfarm or from manual
builds, reproducing this must entail rare operating system
configurations.  Also correct the associated error message, which was
wrong for non-Windows.  Back-patch to v12, where the pgbench check first
appeared.  While v11 vacuumdb has the problematic check, reaching it
with typical vacuumdb usage is implausible.

Reviewed by Thomas Munro.

Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/73cda80a30a552c718f272379476a63d75327fda

Modified Files
--------------
src/bin/pgbench/pgbench.c  | 19 ++++++++++++++-----
src/bin/scripts/vacuumdb.c | 34 +++++++++++++++++++++++++++++-----
2 files changed, 43 insertions(+), 10 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1qrnXz-000aIT-Jq@gemulon.postgresql.org>
Permalink:  ../E1qrnXz-000aIT-Jq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qrnXz-000aIT-Jq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.
  In-Reply-To: <E1qrnXz-000aIT-Jq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox