pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move extra code out of the Pre/PostRestoreCommand() section.
Date: Mon, 16 Oct 2023 17:45:06 +0000
Message-ID: <E1qsReM-000sNZ-Eu@gemulon.postgresql.org> (raw)

Move extra code out of the Pre/PostRestoreCommand() section.

If SIGTERM is received within this section, the startup process
will immediately proc_exit() in the signal handler, so it is
inadvisable to include any more code than is required there (as
such code is unlikely to be compatible with doing proc_exit() in a
signal handler).  This commit moves the code recently added to this
section (see 1b06d7bac9 and 7fed801135) to outside of the section.
This ensures that the startup process only calls proc_exit() in its
SIGTERM handler for the duration of the system() call, which is how
this code worked from v8.4 to v14.

Reported-by: Michael Paquier, Thomas Munro
Analyzed-by: Andres Freund
Suggested-by: Tom Lane
Reviewed-by: Michael Paquier, Robert Haas, Thomas Munro, Andres Freund
Discussion: https://postgr.es/m/Y9nGDSgIm83FHcad%40paquier.xyz
Discussion: https://postgr.es/m/20230223231503.GA743455%40nathanxps13
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/882e522d64686ade162091a572118da2562f3569

Modified Files
--------------
src/backend/access/transam/xlogarchive.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1qsReM-000sNZ-Eu@gemulon.postgresql.org>
Permalink:  ../E1qsReM-000sNZ-Eu@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qsReM-000sNZ-Eu@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Move extra code out of the Pre/PostRestoreCommand() section.
  In-Reply-To: <E1qsReM-000sNZ-Eu@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox