pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
6+ messages / 2 participants
[nested] [flat]

* pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
@ 2022-07-19 00:53  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-07-19 00:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

windows: msvc: Define STDIN/OUT/ERR_FILENO.

Because they are not available we've used _fileno(stdin) in some places, but
that doesn't reliably work, because stdin might be closed. This is the
prerequisite of the subsequent commit, fixing a failure introduced in
76e38b37a5.

Author: Andres Freund <andres@anarazel.de>
Reported-By: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Message-Id: 20220520164558.ozb7lm6unakqzezi@alap3.anarazel.de (on pgsql-packagers)
Backpatch: 15-, where 76e38b37a5 came in

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c290e79cf07f5784fd68e726177503a6805c28d6

Modified Files
--------------
src/include/port/win32_msvc/unistd.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
@ 2022-07-19 00:53  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-07-19 00:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

windows: msvc: Define STDIN/OUT/ERR_FILENO.

Because they are not available we've used _fileno(stdin) in some places, but
that doesn't reliably work, because stdin might be closed. This is the
prerequisite of the subsequent commit, fixing a failure introduced in
76e38b37a5.

Author: Andres Freund <andres@anarazel.de>
Reported-By: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Message-Id: 20220520164558.ozb7lm6unakqzezi@alap3.anarazel.de (on pgsql-packagers)
Backpatch: 15-, where 76e38b37a5 came in

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/92f478657c5544eba560047c39eba8a030ddb83e

Modified Files
--------------
src/include/port/win32_msvc/unistd.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
@ 2023-10-17 21:13  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-10-17 21:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

windows: msvc: Define STDIN/OUT/ERR_FILENO.

This commit (c290e79cf0) was originally back-patched to v15.
Commit 97550c0711 added a new use of STDERR_FILENO, and it was
back-patched all the way to v11, thus breaking MSVC builds for v11
through v14.  Since STDERR_FILENO is now needed on older versions,
let's back-patch c290e79cf0 down to v11, too.

Here follows the original commit message describing the change:

Because they are not available we've used _fileno(stdin) in some places, but
that doesn't reliably work, because stdin might be closed. This is the
prerequisite of the subsequent commit, fixing a failure introduced in
76e38b37a5.

Author: Andres Freund <andres@anarazel.de>
Reported-By: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Message-Id: 20220520164558.ozb7lm6unakqzezi@alap3.anarazel.de (on pgsql-packagers)
Discussion: https://postgr.es/m/20231017164517.GA613565%40nathanxps13
Backpatch-through: 11

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/555bc89c9060803d9812ad41765971d8b8a67363

Modified Files
--------------
src/include/port/win32_msvc/unistd.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
@ 2023-10-17 21:13  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-10-17 21:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

windows: msvc: Define STDIN/OUT/ERR_FILENO.

This commit (c290e79cf0) was originally back-patched to v15.
Commit 97550c0711 added a new use of STDERR_FILENO, and it was
back-patched all the way to v11, thus breaking MSVC builds for v11
through v14.  Since STDERR_FILENO is now needed on older versions,
let's back-patch c290e79cf0 down to v11, too.

Here follows the original commit message describing the change:

Because they are not available we've used _fileno(stdin) in some places, but
that doesn't reliably work, because stdin might be closed. This is the
prerequisite of the subsequent commit, fixing a failure introduced in
76e38b37a5.

Author: Andres Freund <andres@anarazel.de>
Reported-By: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Message-Id: 20220520164558.ozb7lm6unakqzezi@alap3.anarazel.de (on pgsql-packagers)
Discussion: https://postgr.es/m/20231017164517.GA613565%40nathanxps13
Backpatch-through: 11

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ebc093fa6481935bfd0ead8d47c8831a1bcf3536

Modified Files
--------------
src/include/port/win32_msvc/unistd.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
@ 2023-10-17 21:13  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-10-17 21:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

windows: msvc: Define STDIN/OUT/ERR_FILENO.

This commit (c290e79cf0) was originally back-patched to v15.
Commit 97550c0711 added a new use of STDERR_FILENO, and it was
back-patched all the way to v11, thus breaking MSVC builds for v11
through v14.  Since STDERR_FILENO is now needed on older versions,
let's back-patch c290e79cf0 down to v11, too.

Here follows the original commit message describing the change:

Because they are not available we've used _fileno(stdin) in some places, but
that doesn't reliably work, because stdin might be closed. This is the
prerequisite of the subsequent commit, fixing a failure introduced in
76e38b37a5.

Author: Andres Freund <andres@anarazel.de>
Reported-By: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Message-Id: 20220520164558.ozb7lm6unakqzezi@alap3.anarazel.de (on pgsql-packagers)
Discussion: https://postgr.es/m/20231017164517.GA613565%40nathanxps13
Backpatch-through: 11

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0e32652a79164965e8ef409bb84804a6e608e9ea

Modified Files
--------------
src/include/port/win32_msvc/unistd.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
@ 2023-10-17 21:13  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-10-17 21:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

windows: msvc: Define STDIN/OUT/ERR_FILENO.

This commit (c290e79cf0) was originally back-patched to v15.
Commit 97550c0711 added a new use of STDERR_FILENO, and it was
back-patched all the way to v11, thus breaking MSVC builds for v11
through v14.  Since STDERR_FILENO is now needed on older versions,
let's back-patch c290e79cf0 down to v11, too.

Here follows the original commit message describing the change:

Because they are not available we've used _fileno(stdin) in some places, but
that doesn't reliably work, because stdin might be closed. This is the
prerequisite of the subsequent commit, fixing a failure introduced in
76e38b37a5.

Author: Andres Freund <andres@anarazel.de>
Reported-By: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Message-Id: 20220520164558.ozb7lm6unakqzezi@alap3.anarazel.de (on pgsql-packagers)
Discussion: https://postgr.es/m/20231017164517.GA613565%40nathanxps13
Backpatch-through: 11

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bc322c73cfaa9d8b93d6894fb591ec1592e98b31

Modified Files
--------------
src/include/port/win32_msvc/unistd.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-10-17 21:13 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 00:53 pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO. Andres Freund <andres@anarazel.de>
2022-07-19 00:53 pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO. Andres Freund <andres@anarazel.de>
2023-10-17 21:13 pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO. Nathan Bossart <nathan@postgresql.org>
2023-10-17 21:13 pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO. Nathan Bossart <nathan@postgresql.org>
2023-10-17 21:13 pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO. Nathan Bossart <nathan@postgresql.org>
2023-10-17 21:13 pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO. Nathan Bossart <nathan@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox