pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
Date: Tue, 17 Oct 2023 21:13:02 +0000
Message-ID: <E1qsrN7-0013as-Qv@gemulon.postgresql.org> (raw)

windows: msvc: Define STDIN/OUT/ERR_FILENO.

This commit (c290e79cf0) was originally back-patched to v15.
Commit 97550c0711 added a new use of STDERR_FILENO, and it was
back-patched all the way to v11, thus breaking MSVC builds for v11
through v14.  Since STDERR_FILENO is now needed on older versions,
let's back-patch c290e79cf0 down to v11, too.

Here follows the original commit message describing the change:

Because they are not available we've used _fileno(stdin) in some places, but
that doesn't reliably work, because stdin might be closed. This is the
prerequisite of the subsequent commit, fixing a failure introduced in
76e38b37a5.

Author: Andres Freund <andres@anarazel.de>
Reported-By: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Message-Id: 20220520164558.ozb7lm6unakqzezi@alap3.anarazel.de (on pgsql-packagers)
Discussion: https://postgr.es/m/20231017164517.GA613565%40nathanxps13
Backpatch-through: 11

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bc322c73cfaa9d8b93d6894fb591ec1592e98b31

Modified Files
--------------
src/include/port/win32_msvc/unistd.h | 8 ++++++++
1 file changed, 8 insertions(+)



view thread (6+ messages)

Message-ID: <E1qsrN7-0013as-Qv@gemulon.postgresql.org>
Permalink:  ../E1qsrN7-0013as-Qv@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qsrN7-0013as-Qv@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: windows: msvc: Define STDIN/OUT/ERR_FILENO.
  In-Reply-To: <E1qsrN7-0013as-Qv@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox