pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clean up some pg_dump tests
Date: Wed, 18 Oct 2023 06:13:04 +0000
Message-ID: <E1qsznj-0017Fj-QM@gemulon.postgresql.org> (raw)

Clean up some pg_dump tests

1) Remove useless entries from "unlike" lists.  Runs that are not
   listed in "like" don't need to be excluded in "unlike".

2) Ensure there is always a "like" list, even if it is empty.  This
   makes the test more self-documenting.

3) Use predefined lists such as %full_runs where appropriate, instead
   of listing all runs separately.

Also add code that checks 1 and 2 automatically and dies with an error
for violations.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/1f8cb371-e84e-434e-0367-6b716fb16fa1@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/41a284411e09a3c0a401cd5ab81fbf1802fe8021

Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 78 +++++++++++-----------------------------
1 file changed, 21 insertions(+), 57 deletions(-)



Message-ID: <E1qsznj-0017Fj-QM@gemulon.postgresql.org>
Permalink:  ../E1qsznj-0017Fj-QM@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qsznj-0017Fj-QM@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Clean up some pg_dump tests
  In-Reply-To: <E1qsznj-0017Fj-QM@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox