pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Rename I/O timing statistics columns to blk_read_time and blk_wr
2+ messages / 2 participants
[nested] [flat]

* pgsql: Rename I/O timing statistics columns to blk_read_time and blk_wr
@ 2012-04-29 22:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2012-04-29 22:13 UTC (permalink / raw)
  To: pgsql-committers

Rename I/O timing statistics columns to blk_read_time and blk_write_time.

This seems more consistent with the pre-existing choices for names of
other statistics columns.  Rename assorted internal identifiers to match.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1dd89eadcd2648d7ca0baed3c7af16a04eb1aa26

Modified Files
--------------
.../pg_stat_statements--1.0--1.1.sql               |    4 +-
.../pg_stat_statements/pg_stat_statements--1.1.sql |    4 +-
contrib/pg_stat_statements/pg_stat_statements.c    |   30 ++++++++++----------
doc/src/sgml/monitoring.sgml                       |    6 +--
doc/src/sgml/pgstatstatements.sgml                 |    4 +-
src/backend/catalog/system_views.sql               |    4 +-
src/backend/commands/explain.c                     |   20 ++++++------
src/backend/executor/instrument.c                  |    6 ++-
src/backend/postmaster/pgstat.c                    |   28 +++++++++---------
src/backend/storage/buffer/bufmgr.c                |    4 +-
src/backend/utils/adt/pgstatfuncs.c                |   12 ++++----
src/include/catalog/catversion.h                   |    2 +-
src/include/catalog/pg_proc.h                      |    4 +-
src/include/executor/instrument.h                  |   12 ++++----
src/include/pgstat.h                               |   16 +++++-----
src/test/regress/expected/rules.out                |    2 +-
16 files changed, 79 insertions(+), 79 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Rename I/O timing statistics columns to shared_blk_{read|write}_
@ 2023-10-19 02:30  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2023-10-19 02:30 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Rename I/O timing statistics columns to shared_blk_{read|write}_time

These two counters, defined in BufferUsage to track respectively the
time spent while reading and writing blocks have historically only
tracked data related to shared buffers, when track_io_timing is enabled.

An upcoming patch to add specific counters for local buffers will take
advantage of this rename as it has come up that no data is currently
tracked for local buffers, and tracking local and shared buffers using
the same fields would be inconsistent with the treatment done for temp
buffers.  Renaming the existing fields clarifies what the block type of
each stats field is.

pg_stat_statement is updated to reflect the rename.  No extension
version bump is required as 5a3423ad8ee17 has done one, affecting v17~.

Author: Nazir Bilal Yavuz
Reviewed-by: Robert Haas, Melanie Plageman
Discussion: https://postgr.es/m/CAN55FZ19Ss279mZuqGbuUNxka0iPbLgYuOQXqAKewrjNrp27VA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/13d00729d422c84b1764c24251abcc785ea4adb1

Modified Files
--------------
.../pg_stat_statements/expected/oldextversions.out |   4 +-
.../pg_stat_statements--1.10--1.11.sql             |   4 +-
contrib/pg_stat_statements/pg_stat_statements.c    |  14 +--
doc/src/sgml/pgstatstatements.sgml                 |   8 +-
src/backend/commands/explain.c                     |  29 +++---
src/backend/executor/instrument.c                  |  12 +--
src/backend/utils/activity/pgstat_io.c             |   4 +-
src/include/executor/instrument.h                  |   4 +-
src/test/regress/expected/explain.out              | 108 ++++++++++-----------
9 files changed, 95 insertions(+), 92 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-10-19 02:30 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2012-04-29 22:13 pgsql: Rename I/O timing statistics columns to blk_read_time and blk_wr Tom Lane <tgl@sss.pgh.pa.us>
2023-10-19 02:30 pgsql: Rename I/O timing statistics columns to shared_blk_{read|write}_ Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox