From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename I/O timing statistics columns to shared_blk_{read|write}_
Date: Thu, 19 Oct 2023 02:30:42 +0000
Message-ID: <E1qtIo5-001GDr-Ro@gemulon.postgresql.org> (raw)
Rename I/O timing statistics columns to shared_blk_{read|write}_time
These two counters, defined in BufferUsage to track respectively the
time spent while reading and writing blocks have historically only
tracked data related to shared buffers, when track_io_timing is enabled.
An upcoming patch to add specific counters for local buffers will take
advantage of this rename as it has come up that no data is currently
tracked for local buffers, and tracking local and shared buffers using
the same fields would be inconsistent with the treatment done for temp
buffers. Renaming the existing fields clarifies what the block type of
each stats field is.
pg_stat_statement is updated to reflect the rename. No extension
version bump is required as 5a3423ad8ee17 has done one, affecting v17~.
Author: Nazir Bilal Yavuz
Reviewed-by: Robert Haas, Melanie Plageman
Discussion: https://postgr.es/m/CAN55FZ19Ss279mZuqGbuUNxka0iPbLgYuOQXqAKewrjNrp27VA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/13d00729d422c84b1764c24251abcc785ea4adb1
Modified Files
--------------
.../pg_stat_statements/expected/oldextversions.out | 4 +-
.../pg_stat_statements--1.10--1.11.sql | 4 +-
contrib/pg_stat_statements/pg_stat_statements.c | 14 +--
doc/src/sgml/pgstatstatements.sgml | 8 +-
src/backend/commands/explain.c | 29 +++---
src/backend/executor/instrument.c | 12 +--
src/backend/utils/activity/pgstat_io.c | 4 +-
src/include/executor/instrument.h | 4 +-
src/test/regress/expected/explain.out | 108 ++++++++++-----------
9 files changed, 95 insertions(+), 92 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rename I/O timing statistics columns to shared_blk_{read|write}_
In-Reply-To: <E1qtIo5-001GDr-Ro@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox