pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Optimize various aggregate deserialization functions, take 2
Date: Thu, 26 Oct 2023 21:42:13 +0000
Message-ID: <E1qw87J-002U2z-FB@gemulon.postgresql.org> (raw)

Optimize various aggregate deserialization functions, take 2

f0efa5aec added initReadOnlyStringInfo to allow a StringInfo to be
initialized from an existing buffer and also relaxed the requirement
that a StringInfo's buffer must be NUL terminated at data[len].  Now
that we have that, there's no need for these aggregate deserial
functions to use appendBinaryStringInfo() as that rather wastefully
palloc'd a new buffer and memcpy'd in the bytea's buffer.  Instead, we can
just use the bytea's buffer and point the StringInfo directly to that
using the new initializer function.

In Amdahl's law, this speeds up the serial portion of parallel
aggregates and makes sum(numeric), avg(numeric), var_pop(numeric),
var_samp(numeric), variance(numeric), stddev_pop(numeric),
stddev_samp(numeric), stddev(numeric), array_agg(anyarray),
string_agg(text) and string_agg(bytea) scale better in parallel queries.

Author: David Rowley
Discussion: https://postgr.es/m/CAApHDvr%3De-YOigriSHHm324a40HPqcUhSp6pWWgjz5WwegR%3DcQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0c882a298881056176a27ccc44c5c3bb7c8f308c

Modified Files
--------------
src/backend/utils/adt/array_userfuncs.c | 20 +++++++----------
src/backend/utils/adt/numeric.c         | 40 +++++++++++++--------------------
src/backend/utils/adt/varlena.c         | 10 ++++-----
3 files changed, 28 insertions(+), 42 deletions(-)



view thread (2+ messages)

Message-ID: <E1qw87J-002U2z-FB@gemulon.postgresql.org>
Permalink:  ../E1qw87J-002U2z-FB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qw87J-002U2z-FB@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Optimize various aggregate deserialization functions, take 2
  In-Reply-To: <E1qw87J-002U2z-FB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox