pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove buffers_backend and buffers_backend_fsync from pg_stat_ch
Date: Fri, 27 Oct 2023 02:17:46 +0000
Message-ID: <E1qwCPx-002W1y-Qm@gemulon.postgresql.org> (raw)

Remove buffers_backend and buffers_backend_fsync from pg_stat_checkpointer

Two attributes related to checkpointer statistics are removed in this
commit:
- buffers_backend, that counts the number of buffers written directly by
a backend.
- buffers_backend_fsync, that counts the number of times a backend had
to do fsync() by its own.

These are actually not checkpointer properties but backend properties.
Also, pg_stat_io provides a more accurate and equivalent report of these
numbers, by tracking all the I/O stats related to backends, including
writes and fsyncs, so storing them in pg_stat_checkpointer was
redundant.

Thanks also to Robert Haas and Amit Kapila for their input.

Bump catalog version.

Author: Bharath Rupireddy
Reviewed-by: Bertrand Drouvot, Andres Freund
Discussion: https://postgr.es/m/20230210004604.mcszbscsqs3bc5nx@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/74604a37f2f9eb6e626a4ff3cedd02aef5a2ad59

Modified Files
--------------
doc/src/sgml/monitoring.sgml                     | 20 ---------------
src/backend/catalog/system_views.sql             |  2 --
src/backend/postmaster/checkpointer.c            | 32 ++----------------------
src/backend/utils/activity/pgstat_checkpointer.c |  4 ---
src/backend/utils/adt/pgstatfuncs.c              | 12 ---------
src/include/catalog/catversion.h                 |  2 +-
src/include/catalog/pg_proc.dat                  |  9 -------
src/include/pgstat.h                             |  2 --
src/test/regress/expected/rules.out              |  2 --
9 files changed, 3 insertions(+), 82 deletions(-)



Message-ID: <E1qwCPx-002W1y-Qm@gemulon.postgresql.org>
Permalink:  ../E1qwCPx-002W1y-Qm@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qwCPx-002W1y-Qm@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove buffers_backend and buffers_backend_fsync from pg_stat_ch
  In-Reply-To: <E1qwCPx-002W1y-Qm@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox