pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix calculation in brin_minmax_multi_distance_date
Date: Fri, 27 Oct 2023 16:59:57 +0000
Message-ID: <E1qwQBg-002dLW-N3@gemulon.postgresql.org> (raw)

Fix calculation in brin_minmax_multi_distance_date

When calculating the distance between date values, make sure to subtract
them in the right order, i.e. (larger - smaller).

The distance is used to determine which values to merge, and is expected
to be a positive value. The code unfortunately did the subtraction in
the opposite order, i.e. (smaller - larger), thus producing negative
values and merging values the most distant values first.

The resulting index is correct (i.e. produces correct results), but may
be significantly less efficient. This affects all minmax-multi indexes
on date columns.

Backpatch to 14, where minmax-multi indexes were introduced.

Reported-by: Ashutosh Bapat
Reviewed-by: Ashutosh Bapat, Dean Rasheed
Backpatch-through: 14
Discussion: https://postgr.es/m/eef0ea8c-4aaa-8d0d-027f-58b1f35dd170@enterprisedb.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d1740e169d950d457907bbfa32f39f79c8504e20

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c |  7 ++++++-
src/test/regress/expected/brin_multi.out    | 20 ++++++++++++++++++++
src/test/regress/sql/brin_multi.sql         | 18 ++++++++++++++++++
3 files changed, 44 insertions(+), 1 deletion(-)



view thread (4+ messages)

Message-ID: <E1qwQBg-002dLW-N3@gemulon.postgresql.org>
Permalink:  ../E1qwQBg-002dLW-N3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qwQBg-002dLW-N3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix calculation in brin_minmax_multi_distance_date
  In-Reply-To: <E1qwQBg-002dLW-N3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox