pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Teach pg_dump about the new pg_subscription.subrunasowner option
Date: Sun, 29 Oct 2023 16:56:52 +0000
Message-ID: <E1qx95o-002yv9-3Q@gemulon.postgresql.org> (raw)

Teach pg_dump about the new pg_subscription.subrunasowner option.

Among numerous other oversights, commit 482675987 neglected to fix
pg_dump to dump this new subscription option.  Since the new default
is "false" while the previous behavior corresponds to "true", this
would cause legacy subscriptions to silently change behavior during
dump/reload or pg_upgrade.  That seems like a bad idea.  Even if it
was intended, failing to preserve the option once set in a new
installation is certainly not OK.

While here, reorder associated stanzas in pg_dump to match the
field order in pg_subscription, in hopes of reducing the impression
that all this code was written with the aid of a dartboard.

Back-patch to v16 where this new field was added.

Philip Warner (cosmetic tweaks by me)

Discussion: https://postgr.es/m/20231027042539.01A3A220F0A@thebes.rime.com.au

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5ba4cc309095eb1a947961e66b9c5156efc8ffca

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 64 ++++++++++++++++++++++++++++-------------------
src/bin/pg_dump/pg_dump.h |  9 ++++---
2 files changed, 43 insertions(+), 30 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1qx95o-002yv9-3Q@gemulon.postgresql.org>
Permalink:  ../E1qx95o-002yv9-3Q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qx95o-002yv9-3Q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Teach pg_dump about the new pg_subscription.subrunasowner option
  In-Reply-To: <E1qx95o-002yv9-3Q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox