From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: amcheck: Distinguish interrupted page deletion from corruption.
Date: Mon, 30 Oct 2023 21:47:09 +0000
Message-ID: <E1qxa6G-003AIb-OZ@gemulon.postgresql.org> (raw)
amcheck: Distinguish interrupted page deletion from corruption.
This prevents false-positive reports about "the first child of leftmost
target page is not leftmost of its level", "block %u is not leftmost"
and "left link/right link pair". They appeared if amcheck ran before
VACUUM cleaned things, after a cluster exited recovery between the
first-stage and second-stage WAL records of a deletion. Back-patch to
v11 (all supported versions).
Reviewed by Peter Geoghegan.
Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3c6a05b805c750771dc6d3471ca32b27eb25b33e
Modified Files
--------------
contrib/amcheck/Makefile | 1 +
contrib/amcheck/meson.build | 1 +
contrib/amcheck/t/005_pitr.pl | 82 ++++++++++++++++++++++++++++++++++++++++
contrib/amcheck/verify_nbtree.c | 83 +++++++++++++++++++++++++++++++++++++++--
4 files changed, 163 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: amcheck: Distinguish interrupted page deletion from corruption.
In-Reply-To: <E1qxa6G-003AIb-OZ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox