pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: amcheck: Distinguish interrupted page deletion from corruption. 7+ messages / 1 participants [nested] [flat]
* pgsql: amcheck: Distinguish interrupted page deletion from corruption. @ 2023-10-30 21:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2023-10-30 21:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Distinguish interrupted page deletion from corruption. This prevents false-positive reports about "the first child of leftmost target page is not leftmost of its level", "block %u is not leftmost" and "left link/right link pair". They appeared if amcheck ran before VACUUM cleaned things, after a cluster exited recovery between the first-stage and second-stage WAL records of a deletion. Back-patch to v11 (all supported versions). Reviewed by Peter Geoghegan. Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6ec9e9975eff5260651d84ed8bcfd8ecb08e5fbb Modified Files -------------- contrib/amcheck/Makefile | 1 + contrib/amcheck/meson.build | 1 + contrib/amcheck/t/005_pitr.pl | 82 ++++++++++++++++++++++++++++++++++++++++ contrib/amcheck/verify_nbtree.c | 83 +++++++++++++++++++++++++++++++++++++++-- 4 files changed, 163 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: amcheck: Distinguish interrupted page deletion from corruption. @ 2023-10-30 21:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2023-10-30 21:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Distinguish interrupted page deletion from corruption. This prevents false-positive reports about "the first child of leftmost target page is not leftmost of its level", "block %u is not leftmost" and "left link/right link pair". They appeared if amcheck ran before VACUUM cleaned things, after a cluster exited recovery between the first-stage and second-stage WAL records of a deletion. Back-patch to v11 (all supported versions). Reviewed by Peter Geoghegan. Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3c6a05b805c750771dc6d3471ca32b27eb25b33e Modified Files -------------- contrib/amcheck/Makefile | 1 + contrib/amcheck/meson.build | 1 + contrib/amcheck/t/005_pitr.pl | 82 ++++++++++++++++++++++++++++++++++++++++ contrib/amcheck/verify_nbtree.c | 83 +++++++++++++++++++++++++++++++++++++++-- 4 files changed, 163 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: amcheck: Distinguish interrupted page deletion from corruption. @ 2023-10-30 21:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2023-10-30 21:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Distinguish interrupted page deletion from corruption. This prevents false-positive reports about "the first child of leftmost target page is not leftmost of its level", "block %u is not leftmost" and "left link/right link pair". They appeared if amcheck ran before VACUUM cleaned things, after a cluster exited recovery between the first-stage and second-stage WAL records of a deletion. Back-patch to v11 (all supported versions). Reviewed by Peter Geoghegan. Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6f81386a9cea39b83e24943224569ec18557163c Modified Files -------------- contrib/amcheck/Makefile | 1 + contrib/amcheck/t/005_pitr.pl | 83 +++++++++++++++++++++++++++++++++++++++++ contrib/amcheck/verify_nbtree.c | 83 +++++++++++++++++++++++++++++++++++++++-- 3 files changed, 163 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: amcheck: Distinguish interrupted page deletion from corruption. @ 2023-10-30 21:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2023-10-30 21:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Distinguish interrupted page deletion from corruption. This prevents false-positive reports about "the first child of leftmost target page is not leftmost of its level", "block %u is not leftmost" and "left link/right link pair". They appeared if amcheck ran before VACUUM cleaned things, after a cluster exited recovery between the first-stage and second-stage WAL records of a deletion. Back-patch to v11 (all supported versions). Reviewed by Peter Geoghegan. Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/42496cba60bc086f3fdba4b3d20426e27100fbfb Modified Files -------------- contrib/amcheck/t/005_pitr.pl | 89 +++++++++++++++++++++++++++++++++++++++++ contrib/amcheck/verify_nbtree.c | 83 ++++++++++++++++++++++++++++++++++++-- 2 files changed, 168 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: amcheck: Distinguish interrupted page deletion from corruption. @ 2023-10-30 21:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2023-10-30 21:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Distinguish interrupted page deletion from corruption. This prevents false-positive reports about "the first child of leftmost target page is not leftmost of its level", "block %u is not leftmost" and "left link/right link pair". They appeared if amcheck ran before VACUUM cleaned things, after a cluster exited recovery between the first-stage and second-stage WAL records of a deletion. Back-patch to v11 (all supported versions). Reviewed by Peter Geoghegan. Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f31ccb575ed6563b8490cb600ec083ef4b6634bf Modified Files -------------- contrib/amcheck/t/005_pitr.pl | 88 +++++++++++++++++++++++++++++++++++++++++ contrib/amcheck/verify_nbtree.c | 79 +++++++++++++++++++++++++++++++++--- 2 files changed, 162 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: amcheck: Distinguish interrupted page deletion from corruption. @ 2023-10-30 21:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2023-10-30 21:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Distinguish interrupted page deletion from corruption. This prevents false-positive reports about "the first child of leftmost target page is not leftmost of its level", "block %u is not leftmost" and "left link/right link pair". They appeared if amcheck ran before VACUUM cleaned things, after a cluster exited recovery between the first-stage and second-stage WAL records of a deletion. Back-patch to v11 (all supported versions). Reviewed by Peter Geoghegan. Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3a205c91665fddf76e333844884354874dc8ae1b Modified Files -------------- contrib/amcheck/t/005_pitr.pl | 88 +++++++++++++++++++++++++++++++++++++++++ contrib/amcheck/verify_nbtree.c | 76 +++++++++++++++++++++++++++++++++-- 2 files changed, 160 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: amcheck: Distinguish interrupted page deletion from corruption. @ 2023-10-30 21:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2023-10-30 21:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Distinguish interrupted page deletion from corruption. This prevents false-positive reports about "the first child of leftmost target page is not leftmost of its level", "block %u is not leftmost" and "left link/right link pair". They appeared if amcheck ran before VACUUM cleaned things, after a cluster exited recovery between the first-stage and second-stage WAL records of a deletion. Back-patch to v11 (all supported versions). Reviewed by Peter Geoghegan. Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e04509f3246df6cfd96ff5a47f7facd459c72f2b Modified Files -------------- contrib/amcheck/verify_nbtree.c | 76 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 72 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2023-10-30 21:47 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-10-30 21:47 pgsql: amcheck: Distinguish interrupted page deletion from corruption. Noah Misch <noah@leadboat.com> 2023-10-30 21:47 pgsql: amcheck: Distinguish interrupted page deletion from corruption. Noah Misch <noah@leadboat.com> 2023-10-30 21:47 pgsql: amcheck: Distinguish interrupted page deletion from corruption. Noah Misch <noah@leadboat.com> 2023-10-30 21:47 pgsql: amcheck: Distinguish interrupted page deletion from corruption. Noah Misch <noah@leadboat.com> 2023-10-30 21:47 pgsql: amcheck: Distinguish interrupted page deletion from corruption. Noah Misch <noah@leadboat.com> 2023-10-30 21:47 pgsql: amcheck: Distinguish interrupted page deletion from corruption. Noah Misch <noah@leadboat.com> 2023-10-30 21:47 pgsql: amcheck: Distinguish interrupted page deletion from corruption. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox