pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix 003_check_guc.pl when loading modules with custom GUCs
Date: Thu, 02 Nov 2023 03:38:51 +0000
Message-ID: <E1qyOXi-003WhC-Lq@gemulon.postgresql.org> (raw)

Fix 003_check_guc.pl when loading modules with custom GUCs

The test missed that custom GUCs need to be ignored from the list of
parameters that can exist in postgresql.conf.sample.  This caused the
test to fail on a server where such a module is loaded, when using
EXTRA_INSTALL and TEMP_CONFIG, for instance.

Author: Anton A. Melnikov
Discussion: https://postgr.es/m/fc5509ce-5144-4dac-8d13-21793da44fc5@postgrespro.ru
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/40d5e5981cc0fa81710dc2399b063a522c36fd68

Modified Files
--------------
src/test/modules/test_misc/t/003_check_guc.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1qyOXi-003WhC-Lq@gemulon.postgresql.org>
Permalink:  ../E1qyOXi-003WhC-Lq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qyOXi-003WhC-Lq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix 003_check_guc.pl when loading modules with custom GUCs
  In-Reply-To: <E1qyOXi-003WhC-Lq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox