pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize postgres_fdw tests on 32-bit machines
Date: Thu, 02 Nov 2023 23:35:56 +0000
Message-ID: <E1qyhEB-003ekg-RA@gemulon.postgresql.org> (raw)

Stabilize postgres_fdw tests on 32-bit machines

cac169d68 adjusted DEFAULT_FDW_TUPLE_COST and that seems to have caused
a test to become unstable on 32-bit machines.

4b14e1871 tried to fix this as originally the plan was flipping between
a Nested Loop and Hash Join.  That commit forced the Nested Loop, but
there's still flexibility to push or not push the sort to the remote
server and 32-bit seems to prefer to push and on 64-bit, the costs
prefer not to.

Here let's just turn off enable_sort to significantly encourage the sort
to take place on the remote server.

Reported-by: Michael Paquier, Richard Guo
Discussion: https://postgr.es/m/ZUM2IhA8X2lrG50K@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b690e5facb4fbd2600dc477cfe64415538d306cc

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 29 +++++++++++++-------------
contrib/postgres_fdw/sql/postgres_fdw.sql      |  2 ++
2 files changed, 16 insertions(+), 15 deletions(-)



Message-ID: <E1qyhEB-003ekg-RA@gemulon.postgresql.org>
Permalink:  ../E1qyhEB-003ekg-RA@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qyhEB-003ekg-RA@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Stabilize postgres_fdw tests on 32-bit machines
  In-Reply-To: <E1qyhEB-003ekg-RA@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox