pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Doc: update CREATE RULE ref page's hoary discussion of views.
Date: Fri, 03 Nov 2023 15:48:38 +0000
Message-ID: <E1qywPW-003lIm-Hb@gemulon.postgresql.org> (raw)

Doc: update CREATE RULE ref page's hoary discussion of views.

This text left one with the impression that an ON SELECT rule could
be attached to a plain table, which has not been true since commit
264c06820 (meaning the text was already misleading when written,
evidently by me in 96bd67f61).  However, it didn't get really bad
until b23cd185f removed the convert-a-table-to-a-view logic, which
had made it possible for scripts that thought they were attaching
ON SELECTs to tables to still work.

Rewrite into a form that makes it clear that an ON SELECT rule
is better regarded as an implementation detail of a view.
Pre-v16, point out that adding ON SELECT to a table actually
converts it to a view.

Per bug #18178 from Joshua Uyehara.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/18178-05534d7064044d2d@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/58d3283b675639a72faaef669371d71423be441b

Modified Files
--------------
doc/src/sgml/ref/create_rule.sgml | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1qywPW-003lIm-Hb@gemulon.postgresql.org>
Permalink:  ../E1qywPW-003lIm-Hb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qywPW-003lIm-Hb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Doc: update CREATE RULE ref page's hoary discussion of views.
  In-Reply-To: <E1qywPW-003lIm-Hb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox