From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prohibit max_slot_wal_keep_size to value other than -1 during up
Date: Fri, 10 Nov 2023 03:27:13 +0000
Message-ID: <E1r1IAr-004jsP-7Y@gemulon.postgresql.org> (raw)
Prohibit max_slot_wal_keep_size to value other than -1 during upgrade.
We don't want existing slots in the old cluster to get invalidated during
the upgrade. During an upgrade, we set this variable to -1 via the command
line in an attempt to prevent such invalidations, but users have ways to
override it. This patch ensures the value is not overridden by the user.
Author: Kyotaro Horiguchi
Reviewed-by: Peter Smith, Alvaro Herrera
Discussion: http://postgr.es/m/20231027.115759.2206827438943188717.horikyota.ntt@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8bfb231b43d7f6058041483f2b823dd52eac7bf8
Modified Files
--------------
src/backend/access/transam/xlog.c | 19 +++++++++++++++++++
src/backend/replication/slot.c | 16 +++++-----------
src/backend/utils/misc/guc_tables.c | 2 +-
src/include/utils/guc_hooks.h | 2 ++
4 files changed, 27 insertions(+), 12 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prohibit max_slot_wal_keep_size to value other than -1 during up
In-Reply-To: <E1r1IAr-004jsP-7Y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox