pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use REGBUF_NO_CHANGE at one more place in the hash index.
Date: Mon, 13 Nov 2023 08:48:13 +0000
Message-ID: <E1r2Sc9-005D1m-Bz@gemulon.postgresql.org> (raw)

Use REGBUF_NO_CHANGE at one more place in the hash index.

Commit 00d7fb5e2e started to use REGBUF_NO_CHANGE at a few places in the
code where we register the buffer before marking it dirty but missed
updating one of the code flows in the hash index where we free the overflow
page without any live tuples on it.

Author: Amit Kapila and Hayato Kuroda
Discussion: http://postgr.es/m/f045c8f7-ee24-ead6-3679-c04a43d21351@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/861f86beea1c241943a3ef000e789f18bbc8b7e8

Modified Files
--------------
src/backend/access/hash/hash_xlog.c      |  5 +++-
src/backend/access/hash/hashovfl.c       | 19 ++++++++++++++-
src/test/regress/expected/hash_index.out | 29 +++++++++++++++++++++++
src/test/regress/sql/hash_index.sql      | 40 ++++++++++++++++++++++++++++++++
4 files changed, 91 insertions(+), 2 deletions(-)



Message-ID: <E1r2Sc9-005D1m-Bz@gemulon.postgresql.org>
Permalink:  ../E1r2Sc9-005D1m-Bz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1r2Sc9-005D1m-Bz@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use REGBUF_NO_CHANGE at one more place in the hash index.
  In-Reply-To: <E1r2Sc9-005D1m-Bz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox